Implement batch construction for strings columns #17035
Merged
+622
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
feature request
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
force-pushed
the
strings_batch_construction
branch
from
5d6d5e7
to
e252fb4
Compare
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
force-pushed
the
strings_batch_construction
branch
from
92fb05d
to
326d73e
Compare
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
…cuh` Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
force-pushed
the
strings_batch_construction
branch
from
a783d19
to
f8957f1
Compare
davidwendt
approved these changes
Oct 11, 2024
|
Does this supersede #16727? Can that one be closed? |
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
This reverts commit c981e99.
|
There seems to be a failed test and I can't reproduce it locally. Convert into draft while investigating. |
Signed-off-by: Nghia Truong <[email protected]>
This reverts commit 4190cfd.
|
Found the cause of issue, which should be fixed by #17074. Now wait for it to be merged first. |
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
PointKernel
reviewed
Oct 16, 2024
davidwendt
reviewed
Oct 16, 2024
| } | ||
| }(); | ||
| auto chars_data = | ||
| make_chars_buffer(offsets_column->view(), bytes, begin, strings_count, stream, mr); |
There was a problem hiding this comment.
I wonder if this could replace gather_chars in
Out of scope for this PR I think. I can make a note to look into this in a follow on PR.
davidwendt
approved these changes
Oct 16, 2024
Signed-off-by: Nghia Truong <[email protected]>
PointKernel
approved these changes
Oct 16, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements batch construction of strings columns, allowing to create a large number of strings columns at once with minimal overhead of kernel launch and stream synchronization. There should be only one stream sync in the entire column construction process.
Benchmark: #17035 (comment)
Closes #16486.